23835 Commits

Author SHA1 Message Date
Jordan Aasen
4d61897545 [PM-46172] Update toast after adding a shared folder (#24669)
* update shared folder creation i18n content

* update i18n key
2026-11-13 15:44:56 -07:00
Jordan Aasen
df1c77bbf2 [PM-46048] Show item counts on nested folder cards (#24406)
* [PM-46048] feat: Show item counts on nested folder cards

Each card in the folder grid counts the items in its folder and every
folder nested beneath it, so drilling into a folder keeps the total the
parent list showed.

* [PM-46048] fix: Exclude archived items from folder item counts
2026-11-13 15:28:38 -07:00
Ben Brooks
a8237e9a06 [PM-44985] Add fill assist rule qualification and heuristic fallback (#24324)
* [PM-44984] Scaffold fill assist heuristic fallback
* [PM-44985] Add rule qualification interface and heuristic bypass
* [PM-44985] Implement rule qualification
* [PM-44985] Add rule qualification branch to getPageDetails
* [PM-44985] Return envelope from getUrlAutofillTargetingRules
* [PM-44985] Replace RQS LogService with console.debug
* [PM-44985] Wire rule qualification into autofill-init
* [PM-44985] Test bypass cache clearing
* [PM-44985] Align rule qualification with heuristic field filter
* [PM-44985] Treat selectors as alternatives, pierce shadow DOM
* [PM-44985] Narrow extras check and flatten declared loop

---------

Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>
2026-11-13 13:07:52 -08:00
Jared
6fc2336133 [PM-45472] Recover account for read-only admins on table v2 members page (#24650)
* Recover account for read-only admins on table v2 members page

* Fixes from design review critiques

* Fix sizing from Jillian's critiques for design review
2026-11-13 16:02:29 -05:00
Jared
06ba95dd36 [PM-46826] Fix role ordering (#24729)
* Fix role ordering

* Cuts comment down to 1 line
2026-11-13 15:20:09 -05:00
Mike Amirault
892283f4f7 [PM-43238] Fix credit card imports from Dashlane (#24026)
* [PM-43238] Fix credit card imports from Dashlane

* Address AI comment
2026-11-13 13:54:14 -05:00
Isaiah Inuwa
ea55f7b9d3 [PM-46819] Cancel passkey request when the modal window is closed (#24734) 2026-11-13 11:03:02 -06:00
Max
95f5897428 [SM-2108] Land the Secrets Manager CLI stack in main (#24684)
* [SM-2108] Move Secrets Manager services and models to bit-sm (#23925)

* [SM-2109] Return results from Secrets Manager service create, update and restore calls (#23926)

* [SM-2110] Add the feature-flagged bw sm command foundation (#23927)

* [SM-2112] Add bw sm secret and bw sm template commands (#23929)

* [SM-2113] Add bw sm trash commands (#23930)

* [SM-2114] Add bw sm machine-account and access token commands (#23931)

* [SM-2115] Add bw sm access and bw sm grantees commands (#23932)

* [SM-2116] Add Secrets Manager counts, events, import/export and bw serve endpoints (#23933)

---------

Co-authored-by: cd-bitwarden <106776772+cd-bitwarden@users.noreply.github.com>
2026-11-13 16:47:07 +00:00
renovate[bot]
ebe2148cfa [deps] AC: Update core-js to v3.51.0 (#24554)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-11-13 11:46:37 -05:00
Jackson Engstrom
473a21d38d [PM-45616] app-vault-item-dialog not refreshing item info (#24197)
* keep cipher open in dialog in sync

* fix cancel button not working after a failed save

* allow dialog to refresh in AC

* reword comments

* fix potential permission shifting
2026-11-13 08:46:23 -08:00
Nick Krantz
09e5296b1e [PM-46898] fix: Use "My items" casing consistently (#24752)
* [PM-46898] fix: Name new My items collections with myItemsV2

The default user collection was named from the "myItems" key ("My Items"),
while the rest of the UI uses "myItemsV2" ("My items"). Switch the web,
browser, desktop and CLI paths that create the collection to "myItemsV2"
and drop the now-unused "myItems" key. Existing collections keep their
stored name.

* Use errorImportingMyItemsMultiCollectionV2 for the lowercase My items import error

* Label the My items shared folder from i18n in the vault table

* Label the My items shared folder from i18n in the item view and edit form

* Keep other members' emails on their My items collections and test the labels
2026-11-13 10:36:16 -06:00
Jared
dbc5b470b6 Fix bold issue but still follow old table behavior for old members table (#24728) 2026-11-13 11:31:54 -05:00
Jared Snider
0f93346a90 Auth/PM-21300 - Move registration from libs/auth to libs/angular (#24475)
* PM-21300 - Move registration from libs/auth to libs/angular

Relocates the registration feature (registration-start, registration-finish,
registration-link-expired, registration-env-selector) to
libs/angular/src/auth/registration with its own barrel. Browser, desktop, web,
and jslib-services now import from the new location. Adds the libs/angular mdx
glob to Storybook so the registration-start docs page keeps rendering.

* PM-21300 - Remove leftover import comment
2026-11-13 11:12:07 -05:00
Daniel Riera
80507e69c7 PM-44318 Add Autotype Default Keyboard Shortcut to Autotype GA Policy (#24427)
* PM-44318 Add Autotype Default Keyboard Shortcut to Autotype GA Policy

* address aikido feedback

* address design feedback

* address feedback
2026-11-13 14:11:32 +00:00
Oscar Hinton
4b6c72ec2a Pin the Manual Rotation Due story to the story clock (#24746)
The story built its due date from the real clock and the component reads Date.now() for the due age, so Chromatic flagged it on every build.
2026-11-13 08:40:36 -05:00
Oscar Hinton
7cb2858c26 [PAM-617] Look up collection names by id in the access rules filter (#24745)
* PAM-617: count the Shared folders options in one pass and look up collection names by id

* PAM-617: drop the manual Shared folders counts, since the table's own count is fast with the id map
2026-11-13 12:43:29 +01:00
bmbitwarden
cd7189c113 PM-46395 resolved drawer width (#24681) 2026-11-12 15:44:26 -05:00
bmbitwarden
5f44fb5a11 CL-1072 initial commit (#24648) 2026-11-12 15:28:51 -05:00
Jared
4d76bbfb69 Feature flag is no longer required, keep code that is relevant to the feature flag being on. Revoke the rest (#24645) 2026-11-12 14:30:54 -05:00
Jérémy Leherpeur
484911b262 [PM-46804] Add Arbalete browser integration on mac (#24717)
* Add Arbalete browser integration on mac

* Add Arbalete Dev browser integration on mac
2026-11-12 12:58:32 -05:00
Ben Brooks
186a8fe40d [PM-40268] Unwrap fido2 transports for postMessage (#24397)
Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>
2026-11-12 09:45:26 -08:00
Brandon Treston
1f8ab9c5a1 add feature flag (#24657) 2026-11-12 11:01:33 -05:00
Patrick Honkonen
6ea59eede4 [AI-223] llm: Commit SDK evaluation fixes as claude[bot] (#24444) 2026-11-12 10:05:34 -05:00
Matt Andreko
d2a6976d64 [PM-41923] deps: Move web image to Alpine 3.24 (#24593) 2026-11-12 09:04:24 -05:00
Bernd Schoolmann
752719b07c [PM-46038] feat(unlock): Unlock PIN without clicking button (#24304)
* Update sdk-internal to 0.2.0-main.1202

* Implement PIN length storage in JsWasmStateBridge

sdk-internal 0.2.0-main.1202 adds required set/get/clear_pin_length members to WasmStateBridge (bitwarden/sdk-internal#1708). The SDK stores the PIN's character count unencrypted so a lock screen can read it while locked, so it is backed by a new PIN_DISK state key that clears on logout.

* Try the PIN as soon as it is fully typed

Unlocking with a PIN needed a press of Unlock, or Enter, after typing
it. The SDK now stores the PIN's length through the state bridge, and
the lock screen submits the PIN as soon as that many characters are
typed. A wrong PIN of that length counts as an attempt, as if Unlock
was pressed.

The form's submit handler restarted on every submit rather than
ignoring one while the last ran, so the automatic try plus an Enter
cost two of the five allowed attempts. A submit while the PIN is being
tried is now ignored.

The length is stored unencrypted, since the lock screen reads it while
locked.

---------

Co-authored-by: bw-ghapp[bot] <178206702+bw-ghapp[bot]@users.noreply.github.com>
2026-11-12 08:29:07 +09:00
bw-ghapp[bot]
237e30308c Update sdk-internal to 0.2.0-main.1235 (#24631)
Co-authored-by: bw-ghapp[bot] <178206702+bw-ghapp[bot]@users.noreply.github.com>
2026-11-11 16:08:23 -05:00
Stephon Brown
8bb9d5b08b [PM-40544] Default sales and marketing trials to 14 days (#24430)
* feat(billing): default sales and marketing trial length to 14 days

* feat(billing): use the 14-day default in sales and marketing trial copy
2026-11-11 14:21:35 -05:00
Bernd Schoolmann
6b8ce54785 [PM-46036] perf(browser): Stop decrypting and caching the whole vault (#24277) 2026-11-12 03:35:37 +09:00
Bryan Cunningham
a21f43157b [CL-1091] feat: Add a status slot to the avatar (#24602)
Consumers project a bit-berry, which the avatar sizes and places at the top end corner. The
avatar is masked around it instead of drawing a ring, so the gap works on any background.
2026-11-11 12:26:16 -05:00
Brandon Treston
f82b5ea6ea remove feature flag (#24592) 2026-11-11 17:26:01 +00:00
renovate[bot]
4e27539c29 [deps] DIRT: Update chart.js to v4.6.1 (#24555)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-11-11 10:40:10 -06:00
Daniel James Smith
065b0dc613 Update renovate to also keep electron version in electron-builder.beta.json in sync (#24223)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2026-11-11 11:23:09 -05:00
Kyle Denney
656638995a [PM-43274] feat: Add the Privileged Controls purchase to the organization subscription page (#24164)
* [PM-43274] feat: Add Privileged Controls plan pricing and billing flag

* [PM-43274] feat: Add Privileged Controls purchase call to the organization billing client

* [PM-43274] feat: Add the Privileged Controls purchase component

* [PM-43274] feat: Show the Privileged Controls purchase on the subscription page

* [PM-43274] fix: Skip the Privileged Controls purchase when seats are empty

* [PM-43274] fix: Validate the Privileged Controls purchase form before submitting

* [PM-43274] feat: Add the Privileged Controls product logo

The Privileged Controls purchase block needs header art matching the Secrets Manager purchase block. This mirrors SecretsManagerAlt with the product name outlined in DM Sans, the brand font used by the Secrets Manager artwork.

* [PM-43274] feat: Polish the Privileged Controls purchase block

- Show the logo and feature copy in place of the placeholders
- Show the More from Bitwarden heading once when the Secrets Manager purchase is also on the page
- Show the max potential seat cost under the seat limit, as Password Manager does
- Require the seat limit to be a whole number above the seat count so it is a limit the organization can autoscale up to

* [PM-43274] fix: Reject decimal Privileged Controls seat counts

Seats are bought in whole units, but the seat count field accepted values like 10.5.

* [PM-43274] feat: Cap Privileged Controls seats at Password Manager seats

Privileged Controls no longer has a seat minimum. An organization can buy from 1 seat up to its Password Manager seat count, and its Privileged Controls seat limit can't exceed its Password Manager seat limit, or its Password Manager seat count when it has no limit.

- Remove the seat minimum validation, its hint, and the unused defaultSeatMinimum plan field
- Default seats to 1

* [PM-43274] fix: Hide the Privileged Controls purchase when the server reports it

The purchase block checked usePam on the locally synced organization, which stays stale until the client syncs. An organization that got Privileged Controls in another session still saw the purchase offer. Read usePam from the subscription response instead, which the page fetches fresh on load.

* [PM-43274] refactor: Simplify the Privileged Controls purchase form

Keeps every seat check on the field that displays it, so errors show under
the right input without a parent lookup, and drops the enable/disable
toggling that the template's @if already covers. Also hides the purchase for
provider organizations, matching the Secrets Manager subscribe gate.

* [PM-43274] feat: Update Secrets Manager and Privileged Controls purchase copy

Match the updated design copy for the More from Bitwarden cards. Secrets
Manager gets new keys because its existing strings are already translated.

* [PM-43274] fix: Add a space between the slash and interval in purchase prices

* [PM-43274] feat: Hide the Privileged Controls seat limit behind a limit checkbox

Match the Password Manager seat limit pattern so the seat limit is opt-in.
Unchecking the limit clears it so no hidden value is submitted.

* [PM-43274] feat: Apply final Secrets Manager and Privileged Controls copy

Design finalized the More from Bitwarden copy. Privileged Controls gets the
new description and feature list. Secrets Manager gets a new description key,
since the old string is already translated.

* [PM-43274] fix: Use semantic color tokens in the purchase blocks for dark mode

The legacy muted text and secondary border tokens don't match the design in
dark mode. Use fg-body, fg-heading, and border-base, as the design specifies.

* [PM-43274] feat: Drop "included" from the Secrets Manager machine accounts bullet

Match the final design copy. Reuse the existing includedMachineAccountsV2 key,
which already reads "$COUNT$ machine accounts", and remove the now-unused
machineAccountsIncluded key.

* [PM-43274] feat: Show the Secrets Manager and Privileged Controls purchase blocks as accordions

Design asked for each purchase block's header to be an accordion header.
Use the design system accordion's default variant as is, open by default.
The accordion title replaces the header art and in-block title, so remove
the now-unused plan name title code and its strings.

The Secrets Manager block is shared, so the organization plans page and
the legacy subscription page also show the accordion.

* [PM-43274] chore: Remove the unused Secrets Manager and Privileged Controls header art

The purchase blocks now use accordion headers, so nothing references these
SVGs anymore.

* [PM-43274] feat: Update the Privileged Controls seat limit hint copy

Design asked for the hint to say members can't be given access to
Privileged Controls once the limit is reached.

* [PM-43274] fix: Add spacing between the purchase block feature bullets

Design flagged the bullet list as too tight. Add 8px between items, as
the design specifies.

* [PM-43274] chore: Remove the unused subscribeToSecretsManager string

The Secrets Manager purchase checkbox now reads addSecretsManager, so nothing reads this key.

* [PM-43274] test: Fold the Privileged Controls plan parsing assertions into one test

The new test duplicated "parses PrivilegedControls when present", so its seat plan ID and base seats assertions move there.
2026-11-11 10:09:38 -06:00
Vince Grassia
45e4aaae30 [BRE-2407] fix(cli): Choose bw update asset by license type and CPU architecture (#24658)
`bw update` picked the first release zip whose URL contained `bw-<os>`.
It ignored which build was running and the CPU architecture, so OSS users
were sent the commercial build and arm64 users were sent the x64 build.

- Add `licenseType` to the CLI ServiceContainer ("oss"), overridden to
  "bit" in the Bitwarden-licensed container, and pass it to UpdateCommand.
- Build the exact asset name, bw-{license}-{os}[-arm64]-{version}.zip,
  from the license, process.platform, process.arch and the release tag,
  and match it against asset names.
- Fall back to the release page when no matching asset exists or the
  OS/architecture has no published build.
- Type the GitHub release response and remove @ts-strict-ignore.

Depends on the bw-bit-* asset rename (BRE-2408).
2026-11-11 10:22:40 -05:00
Vince Grassia
5e1abff860 [BRE-2408] ci: Prefix commercial CLI artifacts with bw-bit- (#24652)
Commercial CLI zips were unprefixed (bw-linux-*, bw-macos-*, bw-windows-*)
while OSS zips use bw-oss-*. Set the commercial artifact_prefix to -bit so
both license types follow bw-{license}-{os}[-arm64]-{version}.zip, and point
the snap job and snapcraft.yaml at bw-bit-linux-*.
2026-11-11 09:52:03 -05:00
Bryan Cunningham
64694bf040 [CL-1339] Take table v2 out of beta (#24655) 2026-11-11 08:56:35 -05:00
Patrik Svensson
60eec6808d [PAM-577] (3-A11) PAM agent docs and specs: sync with UAT (#24675) 2026-11-11 13:35:18 +00:00
Bernd Schoolmann
688f37d119 Fix shared e2e desktop tests after reload on lock (#24673) 2026-11-11 22:35:14 +09:00
Patrik Svensson
d86602439c [PAM-575] Browser: PAM in the extension (#24667) 2026-11-11 11:15:03 +00:00
Patrik Svensson
88fa09626a [PAM-574] Vault: CipherService stops messaging the overlay (#24659) 2026-11-11 11:01:31 +01:00
Jonathan Prusik
b2471b526b [PM-45264] Wire data backing for HTTP auth cipher-level setting (#24507)
* wire data backing for HTTP auth cipher-level setting

* refactor feature availability check
2026-11-10 17:43:44 -05:00
Oscar Hinton
93ef9aecd1 (B6) Vault: restricted ciphers in the browser popup (#24596)
* Vault: show restricted ciphers in the browser popup

The popup lists restricted (partial) ciphers and swaps in a cipher's
revealed view while one exists. The edit, clone and assign-collections
routes send a blocked restricted cipher back to its view, and the view
page, more-options menu, copy actions, password history and add-edit
respect the restricted-cipher rule.

A host can provide VAULT_ROW_ACCESS for each row's access status and
overflow actions, and contribute list table filters with coloured tiles.
Unprovided, rows show no status and the popup behaves as before.

* Vault: replace the popup's row access seam with neutral slots

Addresses review feedback on #24596.

- Replace VAULT_ROW_ACCESS with VAULT_ROW_ICON (a component slot) and
  VAULT_ROW_SUBTITLE (a text provider). item-more-options renders
  VAULT_ROW_ACTIONS after View, checked against its own built-in IDs.
- Add an optional `disabled` to row actions, honoured by web's menu too,
  and export the contributed action ID check from CipherRowMenuService.
- Drop accessActive from the more-options menu, so edit under a live
  reveal follows the restricted-cipher policy. Clone checks the policy.
- Name the list table's contributed filter generically, key it by the
  provider's `key`, and persist selections as contributedFilterIds.
- Move gating into the row actions (showCopyActions) and launchCipher,
  and drop the separate revealed-ID stream: the list already swaps
  revealed views in for their restricted rows.
- Lift the view footer's edit and restore conditions into the component.
- Drop the five browser strings, which Vault no longer uses.
2026-11-10 21:15:50 +00:00
Andy Pixley
0c7219337f Sign Windows builds with the win-code-signing managed identity over OIDC (#24656)
Based on #23917.

Co-authored-by: addisonbeck <github@addisonbeck.com>
2026-11-10 16:04:45 -05:00
Stephon Brown
3eca4f7da5 [PM-44272] feat: add upgrade-nudge service abstraction and rollout flag (#24649)
* feat(billing): add premium upgrade-nudge service abstraction

* feat(billing): register feature-based upgrade paths rollout flag

* fix(billing): remove TOTP mentioning in comment
2026-11-10 15:20:02 -05:00
Bryan Cunningham
7dd65223f4 Revert OnPush on route-hosting layout shells (#24646) 2026-11-10 14:38:19 -05:00
renovate[bot]
f54be55678 [deps] Platform: Update electron to v43.8.7 (#24651)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-11-10 19:36:04 +00:00
Oscar Hinton
1416af6867 PAM (3-B4): route Autofill's cipher lookups through FillCipherPolicy (#24615)
Extracts FillCipherPolicy from pam/uat. Autofill reads ciphers only
through the policy with a CipherUse. The OSS DefaultFillCipherPolicy
wraps CipherService and changes no behaviour; a commercial build can
supply its own through MainBackground's new overrides argument.

Every user-started fill, the save prompt, the badge, the context menu
and the inline menu go through the policy, and refresh when it reports a
change. An eslint no-restricted-syntax rule blocks direct CipherService
lookups in Autofill.

main.background.ts takes only the policy's hunks. CipherService keeps
its messagingService argument (B5), and the revealedCipherService
override and the public messageListener stay out (A10).
2026-11-10 18:16:01 +00:00
Isaiah Inuwa
8b60b3d94f [PM-46213] Add GetAssertion to win_webauthn (#24515)
* win_webauthn: Add raw GetAssertion types and functions

* win_webauthn: Add safe wrappers for GetAssertion

* win_webauthn: Support the appid extension in GetAssertion
2026-11-10 18:35:56 +01:00
Colton Hurst
187430f5b3 [PM-27100] Autotype Desktop URI Label (#24520)
* [PM-27100] Add the autotype client models, draft

* [PM-27100] URI label change

* [PM-27100] Move autotype pairing data schema to libs/common

* [PM-27100] Add more comments

* [PM-27100] Update this PR based on schema 1.0.0 change from #24468

* [PM-27100] Retain unknown params in uri for future optional compatability

* [PM-27100] Handle non-empty strings

* [PM-27100] Small tests change

* [PM-27100] Small comment change

* [PM-27100] Remove (URI) from text
2026-11-10 12:18:32 -05:00
Oscar Hinton
997aa47f91 [PAM] (3-A9) Bring the access connectors tab to its pam/uat state (#24632)
Takes the access connectors list, detail page and dialogs from pam/uat
byte for byte, deletes rotation/skeleton-delay.ts now that no tab reads
it, and moves the web strings: 27 added, 30 removed, and a corrected
description on pamAccessConnectorAssignmentsNone.
2026-11-10 18:04:57 +01:00