fix: close No-Log telemetry race — guard flush, requeue, beacon, and import

- flushTelemetry() clears buffer and returns immediately when noLogMode is true
- Failed flush never requeues events if noLogMode became true during flight
- beforeunload beacon guarded by !state.noLogMode
- Import path clears telemetry buffer when imported backup has noLogMode enabled

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
faber
2026-07-13 12:01:26 -04:00
parent 466d489a2f
commit 124eb8c51d

View File

@@ -4306,6 +4306,7 @@
}
async function flushTelemetry() {
if (state.noLogMode) { _telemetry.buffer.length = 0; _telemetry.flushing = false; return; }
if (_telemetry.flushing || _telemetry.buffer.length === 0) return;
_telemetry.flushing = true;
@@ -4319,16 +4320,14 @@
});
if (!res.ok) {
// Put events back if flush failed
_telemetry.buffer.unshift(...events);
if (!state.noLogMode) _telemetry.buffer.unshift(...events);
console.warn('[ZDR] Telemetry flush failed:', res.status);
} else {
const result = await res.json().catch(() => ({}));
console.log(`[ZDR] Flushed ${result.accepted || events.length} events → ${result.file || 'HF'}`);
}
} catch (err) {
// Put events back on network error
_telemetry.buffer.unshift(...events);
if (!state.noLogMode) _telemetry.buffer.unshift(...events);
console.warn('[ZDR] Telemetry network error:', err.message);
} finally {
_telemetry.flushing = false;
@@ -4340,8 +4339,7 @@
window.addEventListener('beforeunload', () => {
// Flush any pending debounced state write
if (_saveStatePending) saveStateNow();
if (_telemetry.buffer.length > 0) {
// Use sendBeacon for reliable delivery on page close
if (!state.noLogMode && _telemetry.buffer.length > 0) {
const payload = JSON.stringify({ events: _telemetry.buffer });
navigator.sendBeacon('/api/telemetry', new Blob([payload], { type: 'application/json' }));
}
@@ -16896,6 +16894,7 @@ Ignoring conversation history will cause you to LOSE the evaluation.`;
if (candidate[key] !== undefined) state[key] = candidate[key];
}
if (candidate.apiKey) _apiKeyGeneration++;
if (state.noLogMode) { _telemetry.buffer.length = 0; }
const actualConvCount = state.conversations?.length ?? 0;
let capWarning = '';