From 124eb8c51df830687d51d641e6fb8758b88e8a0d Mon Sep 17 00:00:00 2001 From: faber Date: Mon, 13 Jul 2026 12:01:26 -0400 Subject: [PATCH] =?UTF-8?q?fix:=20close=20No-Log=20telemetry=20race=20?= =?UTF-8?q?=E2=80=94=20guard=20flush,=20requeue,=20beacon,=20and=20import?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - flushTelemetry() clears buffer and returns immediately when noLogMode is true - Failed flush never requeues events if noLogMode became true during flight - beforeunload beacon guarded by !state.noLogMode - Import path clears telemetry buffer when imported backup has noLogMode enabled Co-Authored-By: Claude Opus 4.6 --- index.html | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/index.html b/index.html index 4aa7c0d..5ff43d3 100644 --- a/index.html +++ b/index.html @@ -4306,6 +4306,7 @@ } async function flushTelemetry() { + if (state.noLogMode) { _telemetry.buffer.length = 0; _telemetry.flushing = false; return; } if (_telemetry.flushing || _telemetry.buffer.length === 0) return; _telemetry.flushing = true; @@ -4319,16 +4320,14 @@ }); if (!res.ok) { - // Put events back if flush failed - _telemetry.buffer.unshift(...events); + if (!state.noLogMode) _telemetry.buffer.unshift(...events); console.warn('[ZDR] Telemetry flush failed:', res.status); } else { const result = await res.json().catch(() => ({})); console.log(`[ZDR] Flushed ${result.accepted || events.length} events → ${result.file || 'HF'}`); } } catch (err) { - // Put events back on network error - _telemetry.buffer.unshift(...events); + if (!state.noLogMode) _telemetry.buffer.unshift(...events); console.warn('[ZDR] Telemetry network error:', err.message); } finally { _telemetry.flushing = false; @@ -4340,8 +4339,7 @@ window.addEventListener('beforeunload', () => { // Flush any pending debounced state write if (_saveStatePending) saveStateNow(); - if (_telemetry.buffer.length > 0) { - // Use sendBeacon for reliable delivery on page close + if (!state.noLogMode && _telemetry.buffer.length > 0) { const payload = JSON.stringify({ events: _telemetry.buffer }); navigator.sendBeacon('/api/telemetry', new Blob([payload], { type: 'application/json' })); } @@ -16896,6 +16894,7 @@ Ignoring conversation history will cause you to LOSE the evaluation.`; if (candidate[key] !== undefined) state[key] = candidate[key]; } if (candidate.apiKey) _apiKeyGeneration++; + if (state.noLogMode) { _telemetry.buffer.length = 0; } const actualConvCount = state.conversations?.length ?? 0; let capWarning = '';