Addison Beck 94f7537990 [PM-46275] Default auto-start to off for Mac App Store builds (#24433) (#24441)
* fix(desktop): default autostart off on Mac App Store builds

Apple rejected Bitwarden Desktop 2026.10.3 under App Store Review
Guideline 2.4.5(iii) because the app auto-launches at login without
user consent. That default came from PM-34509 (PR #20002), which made
openAtLogin$ default to true for all desktop builds.

This adds an optional isMacAppStore constructor parameter to
DesktopSettingsService (default false, so existing callers are
unaffected) and makes the unset-state default conditional: false on
Mac App Store builds, true otherwise. No runtime behavior changes yet
since the flag isn't passed at any construction site -- wiring it up
at main.ts:236 and services.module.ts is a separate, already-planned
follow-up commit. This commit's sole purpose is to add the seam and
prove it with the new spec file.

Refs: PM-46275

* fix(desktop): wire isMacAppStore into DesktopSettingsService construction

Completes PM-46275: Mac App Store builds must not auto-launch without
explicit user consent (Apple Guideline 2.4.5(iii)). The prior commit
(d71e5fefeb) added the optional isMacAppStore constructor parameter to
DesktopSettingsService; this commit threads it through at both call
sites that construct the service.

- main.ts: pass isMacAppStore() in the main process constructor call
- services.module.ts: switch the DI provider to useFactory, passing
  ipc.platform.isMacAppStore from the renderer process

(cherry picked from commit 31398ed946)
2026-11-04 21:38:55 +00:00
2024-01-30 06:50:54 -08:00
2021-12-21 15:43:35 +01:00
2022-03-15 15:39:14 -04:00

Bitwarden

GitHub Workflow browser build on main GitHub Workflow CLI build on main GitHub Workflow desktop build on main GitHub Workflow web build on main


Bitwarden Client Applications

This repository houses all Bitwarden client applications except the mobile applications (iOS | android).

Please refer to the Clients section of the Contributing Documentation for build instructions, recommended tooling, code style tips, and lots of other great information to get you started.

We're Hiring!

Interested in contributing in a big way? Consider joining our team! We're hiring for many positions. Please take a look at our Careers page to see what opportunities are currently open as well as what it's like to work at Bitwarden.

Contribute

Code contributions are welcome! Please commit any pull requests against the main branch. Learn more about how to contribute by reading the Contributing Guidelines. Check out the Contributing Documentation for how to get started with your first contribution.

Security audits and feedback are welcome. Please open an issue or email us privately if the report is sensitive in nature. You can read our security policy in the SECURITY.md file.

2026-11-04 21:38:55 +00:00
Languages
TypeScript 89.6%
HTML 4.6%
Rust 2.6%
SCSS 1.1%
MDX 0.9%
Other 1%