* [PM-46048] feat: Show item counts on nested folder cards
Each card in the folder grid counts the items in its folder and every
folder nested beneath it, so drilling into a folder keeps the total the
parent list showed.
* [PM-46048] fix: Exclude archived items from folder item counts
* keep cipher open in dialog in sync
* fix cancel button not working after a failed save
* allow dialog to refresh in AC
* reword comments
* fix potential permission shifting
* [PM-46898] fix: Name new My items collections with myItemsV2
The default user collection was named from the "myItems" key ("My Items"),
while the rest of the UI uses "myItemsV2" ("My items"). Switch the web,
browser, desktop and CLI paths that create the collection to "myItemsV2"
and drop the now-unused "myItems" key. Existing collections keep their
stored name.
* Use errorImportingMyItemsMultiCollectionV2 for the lowercase My items import error
* Label the My items shared folder from i18n in the vault table
* Label the My items shared folder from i18n in the item view and edit form
* Keep other members' emails on their My items collections and test the labels
* PM-21300 - Move registration from libs/auth to libs/angular
Relocates the registration feature (registration-start, registration-finish,
registration-link-expired, registration-env-selector) to
libs/angular/src/auth/registration with its own barrel. Browser, desktop, web,
and jslib-services now import from the new location. Adds the libs/angular mdx
glob to Storybook so the registration-start docs page keeps rendering.
* PM-21300 - Remove leftover import comment
* Update sdk-internal to 0.2.0-main.1202
* Implement PIN length storage in JsWasmStateBridge
sdk-internal 0.2.0-main.1202 adds required set/get/clear_pin_length members to WasmStateBridge (bitwarden/sdk-internal#1708). The SDK stores the PIN's character count unencrypted so a lock screen can read it while locked, so it is backed by a new PIN_DISK state key that clears on logout.
* Try the PIN as soon as it is fully typed
Unlocking with a PIN needed a press of Unlock, or Enter, after typing
it. The SDK now stores the PIN's length through the state bridge, and
the lock screen submits the PIN as soon as that many characters are
typed. A wrong PIN of that length counts as an attempt, as if Unlock
was pressed.
The form's submit handler restarted on every submit rather than
ignoring one while the last ran, so the automatic try plus an Enter
cost two of the five allowed attempts. A submit while the PIN is being
tried is now ignored.
The length is stored unencrypted, since the lock screen reads it while
locked.
---------
Co-authored-by: bw-ghapp[bot] <178206702+bw-ghapp[bot]@users.noreply.github.com>
Consumers project a bit-berry, which the avatar sizes and places at the top end corner. The
avatar is masked around it instead of drawing a ring, so the gap works on any background.
* [PM-43274] feat: Add Privileged Controls plan pricing and billing flag
* [PM-43274] feat: Add Privileged Controls purchase call to the organization billing client
* [PM-43274] feat: Add the Privileged Controls purchase component
* [PM-43274] feat: Show the Privileged Controls purchase on the subscription page
* [PM-43274] fix: Skip the Privileged Controls purchase when seats are empty
* [PM-43274] fix: Validate the Privileged Controls purchase form before submitting
* [PM-43274] feat: Add the Privileged Controls product logo
The Privileged Controls purchase block needs header art matching the Secrets Manager purchase block. This mirrors SecretsManagerAlt with the product name outlined in DM Sans, the brand font used by the Secrets Manager artwork.
* [PM-43274] feat: Polish the Privileged Controls purchase block
- Show the logo and feature copy in place of the placeholders
- Show the More from Bitwarden heading once when the Secrets Manager purchase is also on the page
- Show the max potential seat cost under the seat limit, as Password Manager does
- Require the seat limit to be a whole number above the seat count so it is a limit the organization can autoscale up to
* [PM-43274] fix: Reject decimal Privileged Controls seat counts
Seats are bought in whole units, but the seat count field accepted values like 10.5.
* [PM-43274] feat: Cap Privileged Controls seats at Password Manager seats
Privileged Controls no longer has a seat minimum. An organization can buy from 1 seat up to its Password Manager seat count, and its Privileged Controls seat limit can't exceed its Password Manager seat limit, or its Password Manager seat count when it has no limit.
- Remove the seat minimum validation, its hint, and the unused defaultSeatMinimum plan field
- Default seats to 1
* [PM-43274] fix: Hide the Privileged Controls purchase when the server reports it
The purchase block checked usePam on the locally synced organization, which stays stale until the client syncs. An organization that got Privileged Controls in another session still saw the purchase offer. Read usePam from the subscription response instead, which the page fetches fresh on load.
* [PM-43274] refactor: Simplify the Privileged Controls purchase form
Keeps every seat check on the field that displays it, so errors show under
the right input without a parent lookup, and drops the enable/disable
toggling that the template's @if already covers. Also hides the purchase for
provider organizations, matching the Secrets Manager subscribe gate.
* [PM-43274] feat: Update Secrets Manager and Privileged Controls purchase copy
Match the updated design copy for the More from Bitwarden cards. Secrets
Manager gets new keys because its existing strings are already translated.
* [PM-43274] fix: Add a space between the slash and interval in purchase prices
* [PM-43274] feat: Hide the Privileged Controls seat limit behind a limit checkbox
Match the Password Manager seat limit pattern so the seat limit is opt-in.
Unchecking the limit clears it so no hidden value is submitted.
* [PM-43274] feat: Apply final Secrets Manager and Privileged Controls copy
Design finalized the More from Bitwarden copy. Privileged Controls gets the
new description and feature list. Secrets Manager gets a new description key,
since the old string is already translated.
* [PM-43274] fix: Use semantic color tokens in the purchase blocks for dark mode
The legacy muted text and secondary border tokens don't match the design in
dark mode. Use fg-body, fg-heading, and border-base, as the design specifies.
* [PM-43274] feat: Drop "included" from the Secrets Manager machine accounts bullet
Match the final design copy. Reuse the existing includedMachineAccountsV2 key,
which already reads "$COUNT$ machine accounts", and remove the now-unused
machineAccountsIncluded key.
* [PM-43274] feat: Show the Secrets Manager and Privileged Controls purchase blocks as accordions
Design asked for each purchase block's header to be an accordion header.
Use the design system accordion's default variant as is, open by default.
The accordion title replaces the header art and in-block title, so remove
the now-unused plan name title code and its strings.
The Secrets Manager block is shared, so the organization plans page and
the legacy subscription page also show the accordion.
* [PM-43274] chore: Remove the unused Secrets Manager and Privileged Controls header art
The purchase blocks now use accordion headers, so nothing references these
SVGs anymore.
* [PM-43274] feat: Update the Privileged Controls seat limit hint copy
Design asked for the hint to say members can't be given access to
Privileged Controls once the limit is reached.
* [PM-43274] fix: Add spacing between the purchase block feature bullets
Design flagged the bullet list as too tight. Add 8px between items, as
the design specifies.
* [PM-43274] chore: Remove the unused subscribeToSecretsManager string
The Secrets Manager purchase checkbox now reads addSecretsManager, so nothing reads this key.
* [PM-43274] test: Fold the Privileged Controls plan parsing assertions into one test
The new test duplicated "parses PrivilegedControls when present", so its seat plan ID and base seats assertions move there.
* Vault: show restricted ciphers in the browser popup
The popup lists restricted (partial) ciphers and swaps in a cipher's
revealed view while one exists. The edit, clone and assign-collections
routes send a blocked restricted cipher back to its view, and the view
page, more-options menu, copy actions, password history and add-edit
respect the restricted-cipher rule.
A host can provide VAULT_ROW_ACCESS for each row's access status and
overflow actions, and contribute list table filters with coloured tiles.
Unprovided, rows show no status and the popup behaves as before.
* Vault: replace the popup's row access seam with neutral slots
Addresses review feedback on #24596.
- Replace VAULT_ROW_ACCESS with VAULT_ROW_ICON (a component slot) and
VAULT_ROW_SUBTITLE (a text provider). item-more-options renders
VAULT_ROW_ACTIONS after View, checked against its own built-in IDs.
- Add an optional `disabled` to row actions, honoured by web's menu too,
and export the contributed action ID check from CipherRowMenuService.
- Drop accessActive from the more-options menu, so edit under a live
reveal follows the restricted-cipher policy. Clone checks the policy.
- Name the list table's contributed filter generically, key it by the
provider's `key`, and persist selections as contributedFilterIds.
- Move gating into the row actions (showCopyActions) and launchCipher,
and drop the separate revealed-ID stream: the list already swaps
revealed views in for their restricted rows.
- Lift the view footer's edit and restore conditions into the component.
- Drop the five browser strings, which Vault no longer uses.
* [PM-27100] Add the autotype client models, draft
* [PM-27100] URI label change
* [PM-27100] Move autotype pairing data schema to libs/common
* [PM-27100] Add more comments
* [PM-27100] Update this PR based on schema 1.0.0 change from #24468
* [PM-27100] Retain unknown params in uri for future optional compatability
* [PM-27100] Handle non-empty strings
* [PM-27100] Small tests change
* [PM-27100] Small comment change
* [PM-27100] Remove (URI) from text
Relocates the JWT decode utility to a new libs/common/src/auth/jwt feature
folder. This removes the restricted libs/common -> @bitwarden/auth/common
import from TokenService.
* [PM-45874] Add extension welcome page behind feature flag
* [PM-45874] Remove VFO1 flag references from welcome page
* [PM-45874] Update welcome page background and spacing to match design
* [CL-762] Migrate libs/components to OnPush and signals
Add OnPush change detection to the remaining components and test/story
hosts, converting state that changes outside input/event triggers to
signals so templates stay in sync.
* [CL-762] Migrate UIF-owned app layout components to OnPush and signals
Covers the browser popup footer and extension anon layout wrapper, and the
web layouts, org switcher, and product switcher.
* [CL-762] Restore Signal import in user layout
* [CL-762] Migrate remaining UIF signal suppressions
Convert the menu-item and tab-link disabled inputs, the resize-observer and
password-input-toggle outputs, and the product/navigation switcher story
mock inputs to signals.
* Move SsoUrlService from libs/auth to libs/common
Relocates SsoUrlService and DESKTOP_SSO_CALLBACK to a new
libs/common/src/auth/sso-url feature folder. Browser, desktop, and CLI now
import them from @bitwarden/common/auth/sso-url.
* Rename sso-url feature folder to sso-login
Relocates the fingerprint dialog to a new libs/angular/src/auth/fingerprint-dialog
feature folder with its own barrel. Browser and desktop now import it from
@bitwarden/angular/auth/fingerprint-dialog.
* Move AuthRequestApiService from libs/auth to libs/common
Relocates AuthRequestApiServiceAbstraction and DefaultAuthRequestApiService
to a new libs/common/src/auth/auth-request-api feature folder. Consumers now
import them from @bitwarden/common/auth/auth-request-api, which also removes
a restricted @bitwarden/auth/common import from DeviceManagementComponent.
* Rename auth-request-api feature folder to login-via-auth-request
* [PM-46145] feat: Show Privileged Controls Contact sales on the subscription page when PAM billing support is off
* [PM-46145] feat: Include Privileged Controls in sales-invited trials without the flag
* [PM-46145] feat: Send the sales-assisted token when creating a trial organization
* [PM-46145] fix: Hide Privileged Controls seat counts for sales-initiated trials in the Contact sales block
* [PM-46145] refactor: Share the no-payment trial rule, add Contact sales ids, and document the read-only block
* [PM-46145] fix: Handle errors on no-payment trial organization creation
A rejected create-without-payment request left the Start trial button
spinning with no message. Show the error through the validation service,
always clear the loading state, and stay on the organization step.
* [PM-46145] fix: Reconcile the trial confirmation with what the server provisioned
When the no-payment trial asked for Privileged Controls but the created
organization comes back without it, stop claiming the trial includes it,
show the sales callout on the confirmation step, and log a warning with
the organization id only. Later flag changes keep the claim off.
* [PM-46145] fix: Show a Privileged Controls callout whenever a requested add-on is dropped
With the PAM-billing flag on and the preview cart off, a link asking for
Privileged Controls dropped it with no feedback. Show the callout whenever
Privileged Controls was requested and not included, using a neutral
unavailable message when the flag is on, and keep the sales-only message
when the flag is off. Reword the sales copy so it no longer says "trial",
which a direct-purchase link (no trial period) would otherwise contradict.
Log a warning, without the token, for a sales invitation link that does
not start without payment.
* [PM-46145] refactor: Correct Privileged Controls JSDoc and tidy the specs
Reword JSDoc and comments that overstated or misdescribed behaviour: the
adjust block covers seat and limit adjustment (no removal), the PAM flag
alone does not turn on self-serve, the sales token is honored only with
the sales-assisted path on the no-payment endpoint, and the read-only
block's exclusions are named.
Pin the read-only Contact sales block on a fully cancelled subscription
and on a non-Enterprise organization that has Privileged Controls, drop
the tautological self-serve token spec, and assert the callout on a sales
invitation with no trial period.
* [PM-46145] fix: Show the Privileged Controls Contact sales blocks only while the Privileged Controls flag is on
* [PM-46145] feat: Give sales-initiated trials their own Contact sales copy on the subscription page
* [PM-46145] revert: Leave Privileged Controls out of every trial sign-up while the flag is off
With PamBillingSupport off, the Admin Portal is the only way an organization
gets Privileged Controls. A trial sign-up includes it only when the link asks
for it and self-serve is on; a sales invitation no longer includes it on its
own, and every Privileged Controls link shows the sales callout instead.
Stop forwarding the sales invitation token on the no-payment create request
(OrganizationInformation, OrganizationNoPaymentMethodCreateRequest and the
billing service mapping return to main), and drop the malformed sales link
warning. The registration path still reads the token from the URL.
With the flag off the client never claims Privileged Controls, so the
post-create reconciliation (privilegedControlsNotProvisioned and its
confirmation-step callout) goes too, and the sales callout is inlined in the
organization step. The error handling in createOrganizationOnTrial stays.
* [PM-46145] fix: Show Privileged Controls seats in use for every organization with the add-on
At GA every organization with Privileged Controls looks like a sales-initiated
trial to the platform, so the read-only Contact sales block on the
subscription page now treats them all the same: it shows seats in use out of
total seats ("7 of 10 seats in use") from the server's OccupiedPamSeats and
PamSeats, and one neutral "contact sales" line. The seat limit line and the
sales-trial note are gone, since autoscale is off.
Map OccupiedPamSeats on OrganizationSubscriptionResponse. Add
privilegedControlsSeatsInUse, reword privilegedControlsChangeThroughSales, and
delete privilegedControlsSalesTrialThroughSales and
privilegedControlsSeatLimit.
Unlocks without the master password (PIN, biometrics, PRF) waited for the
encrypted migrations before they left the lock screen. The user key id
backfill migration syncs and posts to the server, so an unreachable server
kept the user on the lock screen until the requests timed out, even though
the vault was unlocked. In the browser passkey popout this also blocked the
return to the passkey picker.
The migrations now run in the background for these unlocks, so the
migrations scheduler can start a second run while the first is active.
The skipped run released the migrator lock in its finally block, which
let a third run overlap the first. The lock is now taken outside the try
block, so only its owner releases it.
Refs #23353
Co-authored-by: ayane-m <amateria@bitwarden.com>
* [PM-38256] Remove pm-30110-sdk-sends-api feature flag
Remove the Pm30110SdkSendsApi feature flag and its checks so the SDK-backed
Send path is the only path.
- Drop the flag from the feature flag enum and defaults.
- Make Send decryption, key rotation and send push-notification sync
SDK-only, and always run the pending Send deletion retry on sync.
- Always apply the 500 MB file Send size limit.
- Delete SendApiServiceSelector and fold SendSdkApiService into
SendApiService. The merged class uses the SDK and makes REST calls itself
for new-file save, cross-instance (apiUrl) access, and the read-back after
each mutation.
- Remove getSend, getSends, putSendRemovePassword and deleteSend from the
SendApiService abstraction; nothing outside the class called them.
- Inject the concrete SendApiService into ShareLinkService so share links
keep resolving it.
- Update DI wiring and tests.
* [PM-38256] fix: Mock policiesByType$ in desktop send component spec
SendPolicyService now calls policiesByType$ unconditionally, so the
PolicyService mock must provide it.
* Rename Send removePassword/putSendRemovePassword to removeAuth (PM-42855)
The server collapsed the old password-only (V1) endpoint into remove-all-auth
(V2) logic a while back (server PR #6929 / PM-31497), so these methods remove
all auth on a Send today -- a password or an email-verification requirement
-- not just a password. Renames removePassword/putSendRemovePassword to
removeAuth/putSendRemoveAuth across SendApiService, SendSdkApiService,
SendApiServiceSelector, and every caller (DefaultSendFormService, send-details/
send-table/send-list components, web/desktop send components, the CLI's
internal call site), and corrects the matching user-facing copy that had the
same password-only framing bug.
Deliberately out of scope, left unchanged: the SDK's own remove_password
(WASM-exposed, a separate breaking change requiring its own SDK release), and
the CLI's public `remove-password` command name/class (SendRemovePasswordCommand)
-- only its internal call to the renamed service method was updated.
* [PM-42855] Show which kind of Send access control is being removed
Label the Send menu item, edit-page button, confirmation dialogs and success
toasts as "Remove password" or "Remove email verification" based on the
Send's authType, falling back to the generic wording when it is unknown. The
menu item now also appears for email-verified Sends.
* [PM-18041] feat: Add IPC transport between popup and background
* [PM-18041] refactor: Align popup IPC with existing transports
Read chrome.runtime.lastError on port disconnect as the desktop transport does, and await
IpcService.init() in the popup as web and desktop do.
* [PM-18041] refactor: Align popup IPC transports with the existing ones
Name the transports after the SDK endpoint they handle, start listening in
init() with receive passed to the constructor, and report disconnects to the
owning service, which removes the session. Move InMemoryIpcSessionRepository
to apps/browser since only the extension uses it.
* [PM-18041] test: Tighten popup IPC transport tests
Check that a send reaches only the addressed port, and drop the tests for
the session repository's Map wrapper and the unreachable destination guard.
* [PM-18041] refactor: Use the SDK's in-memory IPC sessions
The SDK already recovers when a peer restarts and loses its session, at the
cost of one dropped message, the same as the other IPC connections. Drop the
client-managed repository and the disconnect callbacks that only avoided it.
* Ensure ports get removed on disconnect
* feat(ipc): resolve SDK IPC broadcast groups in browser and desktop
Implement the SDK communication backend resolve hook so IpcClient.broadcast
works on the two hubs:
- Browser background resolves AllBrowserForeground to the extension pages
with an open IPC port.
- Desktop main resolves AllBrowserBackground to the connected native
messaging clients, excluding the CLI. This includes the browser's
biometrics connection, which ignores IPC and costs a handshake timeout
per broadcast; that channel is expected to go away once shared unlock
ships.
Every other group resolves to Unsupported. IpcService gains a broadcast
pass-through next to send.
Requires the unreleased sdk-internal broadcast API (branch
coroiu/ipc-broadcast).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Wake extension pages so the background can reach them before they send
The extension page transport opened its port on the first send, so a page
that had not sent anything was not an IPC endpoint and broadcasts to
AllBrowserForeground skipped it. A restarted service worker also lost every
page until it sent again.
Pages now connect when their IPC service starts. The background opens a
bitwarden-ipc-wake port once at startup, which every open extension page
receives; a page that has no port then connects its own. Verified in headless
Chromium: idle popups receive broadcasts, closed popups drop out, and after a
service worker restart an already open popup reconnects and completes a fresh
handshake.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Document broadcast's fatal-error behavior and the desktop biometrics stall
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Update sdk-internal to 0.2.0-main.1157
Picks up the IPC broadcast API (bitwarden/sdk-internal#1652).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Wake extension pages with a runtime message, not a port
A page that listens to runtime.onConnect also receives the other pages'
IPC ports. With two pages open, that keeps a page's port alive after the
service worker stops, so its onDisconnect never fires: the page keeps
posting into a dead port and is missing from AllBrowserForeground after
the restart.
The background now sends the wake signal with runtime.sendMessage and
pages listen on runtime.onMessage, so no extension page registers an
onConnect listener.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Daniel García <dani-garcia@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* Remove access-intelligence-azure-file-storage feature flag
Remove Report-persistence-feature-flag.service/ts and default-report-persistence.service.ts
Update access-intelligence-routing.module.ts to remove old services and default to FileReportPersistenceService.
* Update documentation to be more clear about feature flag changes/removal
* [PM-44685] Add My items to the browser vault switcher
Lists each organization's My items after it in the popup vault switcher, captioned with the
organization's name, and drops it from the Shared folders filter.
* Merge branch 'main' into vault/pm-44685-my-items-vault-switcher
Keeps main's per-user selected vault and stores the collection segment beside it, so
My items restores as itself. Drops a stored My items whose organization no longer has
the collection, which would otherwise loop between the restore and scope guards.
* [CL-1405] Add bit-button-group and use it for table toolbar actions
Add a bit-button-group component that lays out related buttons in a row or
stack, with an `auto` orientation that stacks all buttons once they no longer
fit in a row and a `fullWidth` option for equal-width buttons.
The table toolbar now renders Customize and its `slot=end` buttons in a button
group. They move to their own full-width row whenever they don't fit beside the
search, and once they stack the toolbar switches to its compact layout: the
search fills its row and the filters collapse to the trigger.
* [CL-1405] Measure button group after first render and fonts
Measure the buttons once after the first render, waiting for
`document.fonts.ready` as bitOverflowList does, so the stack decision no
longer depends on a resize firing after the buttons are fully rendered.
Hardcode the story container widths. The `width` arg was assigned onto the
component instance and clobbered its internal width signal.
* [CL-1405] Use the compact toolbar layout once actions leave the search row
Collapse the filters and let the search fill its row as soon as the slot=end buttons move to their own row, rather than only once they stack. Make the button group's stacked signal internal again now the toolbar no longer reads it.
Dragging the scrollbar maps the pointer onto the track, so collapsing the
header moved the track under the pointer, jumped the offset, and flipped
the direction back, which made the header flicker in and out. The
direction now holds for the length of a scrollbar drag and is worked out
again on release.