1258 Commits

Author SHA1 Message Date
Max
95f5897428 [SM-2108] Land the Secrets Manager CLI stack in main (#24684)
* [SM-2108] Move Secrets Manager services and models to bit-sm (#23925)

* [SM-2109] Return results from Secrets Manager service create, update and restore calls (#23926)

* [SM-2110] Add the feature-flagged bw sm command foundation (#23927)

* [SM-2112] Add bw sm secret and bw sm template commands (#23929)

* [SM-2113] Add bw sm trash commands (#23930)

* [SM-2114] Add bw sm machine-account and access token commands (#23931)

* [SM-2115] Add bw sm access and bw sm grantees commands (#23932)

* [SM-2116] Add Secrets Manager counts, events, import/export and bw serve endpoints (#23933)

---------

Co-authored-by: cd-bitwarden <106776772+cd-bitwarden@users.noreply.github.com>
2026-11-13 16:47:07 +00:00
Patrick Honkonen
6ea59eede4 [AI-223] llm: Commit SDK evaluation fixes as claude[bot] (#24444) 2026-11-12 10:05:34 -05:00
Daniel James Smith
065b0dc613 Update renovate to also keep electron version in electron-builder.beta.json in sync (#24223)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2026-11-11 11:23:09 -05:00
Vince Grassia
5e1abff860 [BRE-2408] ci: Prefix commercial CLI artifacts with bw-bit- (#24652)
Commercial CLI zips were unprefixed (bw-linux-*, bw-macos-*, bw-windows-*)
while OSS zips use bw-oss-*. Set the commercial artifact_prefix to -bit so
both license types follow bw-{license}-{os}[-arm64]-{version}.zip, and point
the snap job and snapcraft.yaml at bw-bit-linux-*.
2026-11-11 09:52:03 -05:00
Patrik Svensson
d86602439c [PAM-575] Browser: PAM in the extension (#24667) 2026-11-11 11:15:03 +00:00
Andy Pixley
0c7219337f Sign Windows builds with the win-code-signing managed identity over OIDC (#24656)
Based on #23917.

Co-authored-by: addisonbeck <github@addisonbeck.com>
2026-11-10 16:04:45 -05:00
Bernd Schoolmann
3a689e3dba Fix e2e failures in the usdev run (#24373) 2026-11-09 12:12:00 +00:00
Todd Martin
7e5c83f899 feat(beta): Add Firefox beta build. (#23635) 2026-11-08 20:30:00 -05:00
Oscar Hinton
e20a6533ea [PAM-264] Move shared PAM code to bit-pam and bit-pam-components (#24417)
* [PAM-121] Move shared PAM code to bit-pam and bit-pam-components

Creates two licensed libs owned by team-pam-dev and moves the shared PAM
code into them from bit-web so other clients can consume it:

- bitwarden_license/bit-pam (@bitwarden/bit-pam): framework-free
  abstractions, helpers, date formatting and SDK services, usable from the
  browser background. ESLint keeps Angular and the UI libraries out of it.
- bitwarden_license/bit-pam-components (@bitwarden/bit-pam-components): the
  shared components, pipes, confirm dialogs and Angular-injected services.

Each lib exposes a single barrel. Split out of #22430 to reduce its size;
no behavioural changes.

* [PAM-121] Run Chromatic on bit-pam-components changes

* [PAM-121] Run prettier
2026-11-04 16:06:27 +01:00
brandonbiete
c784de8ce1 [BRE-2231] Download SDK artifacts with actions/download-artifact@v8 (#24179)
The step already receives the build run ID as a required dispatch input,
so it never used the custom action's run lookup.
2026-11-04 09:58:42 -05:00
aj-bw
c41aa5bf81 [BRE-2393] ci: Move desktop_native Rust jobs from macos-14 to macos-26 (#24333) 2026-11-02 13:16:11 +01:00
Bernd Schoolmann
9539b0b269 [PM-46050] ci: Own usdev e2e workflows (#24345) 2026-11-02 05:46:33 +00:00
Bernd Schoolmann
14b867bf3f [PM-46050] ci: Run e2e suites against usdev nightly (#24312) 2026-11-02 14:20:19 +09:00
brandonbiete
a5378e1ee6 [BRE-2391] Disable notarization for macOS beta desktop builds (#24319) 2026-10-30 14:12:09 -04:00
Will Martin
5c055d5100 [CL-1016] Add review guidelines to components CLAUDE.md (#23704)
* [CL-1016] Add review guidelines to components CLAUDE.md

* [CL-1016] Move CL guidelines to CODE_STYLE.md and address review

* [CL-1016] Move scope and process rules to CONTRIBUTING.md

* [CL-1016] Remove external links from CODE_STYLE.md

* [CL-1016] Simplify design sign-off requirement

* [CL-1016] Allow CODE_STYLE.md in capital filename lint

* [CL-1016] Address review feedback on a11y, testing, and promotion guidance
2026-10-30 12:07:22 -04:00
vchauhan-bitwarden
41f307c001 [PM-45197] refactor: Move provider domain into libs/common/src/provider (#24257)
* [PM-45197] refactor: Move provider domain into libs/common/src/provider

* [PM-45197] refactor: Add barrel export for libs/common/src/provider Add libs/common/src/provider/index.ts and import provider types from
@bitwarden/common/provider outside libs/common, so the folder can move
again without touching every consumer. The service implementations stay
out of the barrel because the abstraction and the implementation are
both named ProviderService. Code inside libs/common keeps relative
imports to avoid circular imports. No behavior change.
2026-10-30 20:55:14 +05:30
vchauhan-bitwarden
95182c165d [PM-45196] refactor: Move provider portal to top-level providers folder- #24250 (#24250) 2026-10-30 11:34:55 +05:30
renovate[bot]
817d16b78b [deps]: Update actions/setup-python action to v7 (#22474)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-10-29 21:25:54 +01:00
renovate[bot]
45ec1a3614 [deps]: Update actions/create-github-app-token action to v3 (#19852)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-10-29 21:21:18 +01:00
Andreas Coroiu
0e55460288 ci: Type-check SDK breaking changes without secrets (#24216)
The SDK package can be built from a fork pull request. npm link runs the
package's lifecycle scripts and links its bin entries, and the job also had
an OIDC token and the GitHub App key. Download the package in a separate
job, type-check it in a job without secrets or id-token, and link it with
--ignore-scripts --no-bin-links.
2026-10-28 16:45:56 +01:00
brandonbiete
d315249cad [BRE-2231] Download desktop validation artifacts with actions/download-artifact@v8 (#24178)
The seven validate-* jobs download artifacts from the current run, which
is actions/download-artifact's default, so they never needed the custom
action's run lookup.
2026-10-28 09:11:50 -04:00
Jordan Aasen
6a9e5e4091 [PM-44526] docs: Add Claude rule and contributing guide for vault SDK sync (#23841)
* [PM-44526] docs: Add SDK sync comments to vault domain and view models

Points engineers to the mirrored sdk-internal structs so model changes are also made in the SDK.

* [PM-44526] docs: Add vault CONTRIBUTING guide and SDK-first note on CipherService

Documents that new cipher operations must go through CipherSdkService, and wires the guide into Claude via CLAUDE.md.

* Revert "[PM-44526] docs: Add SDK sync comments to vault domain and view models"

This reverts commit 3d9239222e.

* [PM-44526] docs: Add path-scoped Claude rule for vault SDK sync

Replaces per-model comments with a rule that flags model drift from sdk-internal and CipherService methods that bypass CipherSdkService.

* [PM-44526] docs: Address review feedback on vault SDK sync rule

Widen rule to all data models, note SDK blob schema, point encrypt/decrypt at CipherEncryptionService, and fix password history paths.

* Whitelist vault CONTRIBUTING.md in capital letters check
2026-10-27 08:51:33 -07:00
renovate[bot]
cfb5aea20f [deps]: Update dtolnay/rust-toolchain digest to b725eda (#24141)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-10-26 13:41:21 +01:00
brandonbiete
07f8ba1223 Require label to run Chromatic for fork PRs (#23893)
chromatic-target.yml (pull_request_target, secrets inherited) ran Chromatic
for a fork PR whenever someone with write access opened, pushed to, or
clicked "Update branch" on it, so the fork's code ran with the Chromatic
project tokens without a deliberate review.

- Run chromatic-target.yml only when the shared ci:signed-build label is
  added (same pattern as #23797). check-run still requires the labeler to
  have write access.
- Remove the label once the build starts, so every new commit needs a
  fresh review and label.
- Update the header comments in chromatic-target.yml and chromatic.yml to
  describe the label instead of the manual re-run.

The allow-unsafe-pr-checkout flag in chromatic.yml stays while Chromatic
results are wanted on community PRs.
2026-10-22 14:21:14 -04:00
gitclonebrian
0ad8f11a67 Added downstream artifact build trigger (#24031) 2026-10-22 11:49:33 -04:00
Daniel García
e2969bf1b8 chore: group serde Renovate updates (#23996)
serde_with releases can require a newer serde_json than our exact pin,
so updating it alone fails dependency resolution (see #23510).
2026-10-21 10:10:04 +02:00
Michał Chęciński
ce5386b939 Require label to run browser fork builds (#23807) 2026-10-20 17:44:55 +00:00
Addison Beck
40061b1204 fix: point commercial Chocolatey package at the commercial installer (#23995)
The Windows build runs in OSS and commercial matrix legs (PM-25909).
Each leg's Chocolatey step hashes its own installer, but the
install-script URL was always the non-prefixed (OSS) installer.

The commercial nupkg therefore embedded the commercial installer's
checksum with the OSS installer's URL. Once publishing switched to
the commercial nupkg (BRE-2353), Chocolatey verification for
2026.10.0 failed on a checksum mismatch.

Now each leg's URL uses its own artifact prefix, matching the
release asset commercial-Bitwarden-Installer-<version>.exe. OSS
output is byte-identical to before. The prefix is passed via env,
not inline ${{ }}, per workflow-injection convention.
2026-10-20 08:31:55 -04:00
Isaiah Inuwa
ba7f6ed71a desktop-autofill: Enable macOS autofill extension on stable builds (#23809) 2026-10-16 08:21:32 -05:00
Andreas Coroiu
b830052f94 ci: Make Rust lint blocking through the Lint gate (#23884)
Branch protection on main requires a check named `Lint`, which was the
TypeScript lint job alone. The Rust lint matrix only fed the unrequired
`Rust lint` fan-in, so Rust lint failures never blocked merging.

- Rename the TypeScript job to `Lint TypeScript`.
- Replace `rust-lint` with a `lint-gate` fan-in named `Lint` that needs
  both the TypeScript job and the Rust matrix. It takes over the
  required check name, so no ruleset change is needed.
- Rename the locales-lint job to `Lint locales` so it no longer reports
  a second check named `Lint` on PRs that touch messages.json.

`Rust advisories` stays outside the gate.
2026-10-15 16:24:35 +02:00
Michał Chęciński
0cdf86f754 Require label to run desktop fork builds and fetch signing secrets after the build (#23808) 2026-10-15 14:01:13 +00:00
Andreas Coroiu
4d6c6a3cd9 ci: Run Rust advisories outside the Rust lint gate (#23882)
cargo-deny's advisories check can fail on an unchanged tree as soon as a
new RustSec advisory is published, which blocks unrelated PRs and keeps
the Rust lint jobs from being made required. Split it out:

- `deny` now checks bans, licenses and sources only, and stays in the
  Rust lint matrix.
- A new `advisories` check runs in its own `Rust advisories` job on
  ubuntu-24.04, outside the `Rust lint` gate.
2026-10-15 14:52:45 +02:00
Bernd Schoolmann
3637a20c93 feat(tests): add basic key-management e2e test suite (#23477) 2026-10-14 16:07:02 +00:00
Michał Chęciński
a1f034af9f Require label to run web fork builds and stop fork lite builds (#23806) 2026-10-14 16:03:33 +02:00
Michał Chęciński
5bdb6fc761 Require label to run signed CLI builds for fork PRs (#23797) 2026-10-14 16:03:01 +02:00
Brad
0ab2047fe1 [PM-44917] Browser: Move Health report feature into OSS directory (#23825)
* refactor(dirt): move vault-health data layer to libs/common

* refactor(dirt): update CipherHealthView imports to @bitwarden/common

* feat(browser): move health tab to OSS build

* refactor(browser): reorganize health components into subdirectories

* remove old codeowners entry

* move files to apps/browser/src/dirt/health/popup/ refactor token out of code and move into healthaccessservice instead

* fix import errors

* fix feature flag

* move cipherhealthview into shared dirt models

* update more imports

---------

Co-authored-by: Leslie Tilton <23057410+Banrion@users.noreply.github.com>
2026-10-13 13:01:36 -05:00
Vince Grassia
73d72d8daf Fix ordering (#23831) 2026-10-13 08:42:17 +00:00
renovate[bot]
07a962458e [deps]: Update actions/cache action to v6 (#21955)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-10-12 13:45:49 -05:00
Amy Galles
dd31a5a0c0 ci: Upload commercial macOS App Store build to TestFlight (#23778)
Only the OSS variant of macos-package-mas was uploaded, so the commercial
build couldn't be tested through TestFlight. Both variants share the
com.bitwarden.desktop app and the same build number. The commercial build
now gets a ".1" suffix so App Store Connect doesn't reject it as a
duplicate.
2026-10-12 07:57:15 -07:00
Andy Pixley
ec957c6528 Fixing race condition for safari artifact download (#23766) 2026-10-09 13:12:33 -04:00
Jonathan Prusik
7b80675ab9 [PM-44116] Update renovate dependency updates ownerships (#23486)
* update renovate dependency updates ownerships

* owner updates
2026-10-09 10:06:24 -04:00
brandonbiete
4587fff098 [BRE-2234] Use beta-specific provisioning profiles for macOS beta desktop build (#23703)
* [BRE-2234] Use beta-specific provisioning profiles for macOS beta desktop build

The macOS beta desktop build signed with the stable app's Developer ID
provisioning profiles and shipped an appId that had no matching App ID
registered in the Apple Developer portal.

BRE-2234 registered beta its own identifiers, App Group and provisioning
profiles, so point the beta build at them:

- macos-beta job downloads and installs the beta profiles
- electron-builder.beta.json references the beta Developer ID profile
- appId changes to com.bitwarden.beta.desktop to match the new identifier

The beta profiles are already uploaded to the bitwardenci/profiles
container. Stable jobs are untouched.

* ci: Add entitlements file for beta build

---------

Co-authored-by: Isaiah Inuwa <iinuwa@bitwarden.com>
2026-10-08 14:51:07 +00:00
Addison Beck
0e7970ed40 [PM-40663] Skip npm installs in Renovate to keep lock integrity (#23720) 2026-10-07 16:21:00 -05:00
brandonbiete
c9dda2ec25 [BRE-2234] Use channel-named provisioning profile blobs for stable macOS jobs (#23712)
* [BRE-2234] Use channel-named provisioning profile blobs for stable macOS jobs

The stable macOS jobs download provisioning profiles under names that
don't say which channel they belong to, and one carries a year that no
longer matches its contents:

  bitwarden_desktop_appstore
  bitwarden_desktop_developer_id
  bitwarden_desktop_autofill_app_store_2024
  bitwarden_desktop_autofill_developer_id

Switch to channel-explicit names, matching the bitwarden_beta_desktop_*
set already in use:

  bitwarden_stable_desktop_appstore
  bitwarden_stable_desktop_developer_id
  bitwarden_stable_desktop_autofill_appstore
  bitwarden_stable_desktop_autofill_developer_id

The blobs are already uploaded and hold the same profiles as the names
they replace, so this is a rename at the reference site only. The legacy
blobs stay in place until this lands, then get removed.

Touches macos-build, macos-package-github and macos-package-mas.
macos-beta is handled separately in #23703.

* Update electron-builder and masdev profile references to match

The workflow copies each profile into apps/desktop/ under its blob
filename, and electron-builder resolves it by that name. Renaming the
blobs without updating these would leave the mac and mas sections
pointing at files that no longer exist.

Caught in review by @iinuwa.
2026-10-07 19:53:15 +00:00
Addison Beck
ce9f60c419 [PM-40663] Pin napi-derive-backend for napi 3.8.5 (#23691)
Every Renovate lock-file-maintenance run moves napi-derive-backend to
5.1.x, which breaks desktop_native against the exact napi "=3.8.5" pin:
5.1.x emits bindgen_prelude calls missing from napi 3.8.5.

Pin napi-derive-backend to an exact version napi 3.8.5 supports so
lock-file maintenance can't move it. Remove this pin once napi itself
is upgraded past 3.8.5.
2026-10-07 06:51:04 -04:00
Vince Grassia
ead99df4cf Use correct Safari build for each macOS build (#23677) 2026-10-06 17:20:22 -04:00
Addison Beck
afacce298a [PM-40663] Enforce 7-day cargo publish age for Renovate (#23668) 2026-10-06 08:39:08 +02:00
Isaiah Inuwa
3eec2ba236 Assign passkey_authenticator NAPI module to skunkworks (#23651) 2026-10-05 15:19:30 +00:00
Isaiah Inuwa
fb66010600 ci: Sign Windows Stable Appx (#23600) 2026-10-02 07:10:40 -05:00
Daniel James Smith
934c477f1b Move sass and sass-loader to be owned by UIF (#22488)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2026-09-29 14:09:41 +00:00