mirror of
https://github.com/bitwarden/clients.git
synced 2026-11-16 07:03:29 +00:00
* [PM-43929] Exclude core-js polyfills from Chrome extension build The Chrome Web Store flags core-js's IE-era Object.create shim (ActiveXObject and a hidden-iframe javascript: trick) as obfuscated code. Modern Chrome (auto-updating, floor 134+) natively provides Object.create and explicit resource management (using, Symbol.dispose, DisposableStack), so the Chrome build can ship without the core-js/stable and core-js/proposals/explicit-resource-management imports. Firefox (AMO) and Safari (App Store) keep them; older Safari still lacks native explicit resource management. Implemented as a NormalModuleReplacementPlugin keyed on the BROWSER env var, so source files are unchanged and only the Chrome artifact is affected. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * doc: fix AI comment * [PM-43929] Pin Chrome build to Chrome 134 minimum The Chrome build drops the core-js polyfills that supply Symbol.dispose and explicit resource management, which the SDK's `using ref = sdk.take()` disposal (a core vault-decrypt path) relies on. Chrome provides these natively from 134, but the manifest still declared minimum_chrome_version 102.0, so the Web Store could serve this build to Chrome 102 through 133, where the downleveled `using` helper throws "Symbol.dispose is not defined". Pin minimum_chrome_version to 134 for the Chrome build via a __chrome__ manifest override, so Edge and Opera (which keep core-js) stay at 102. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * [PM-43929] Require Chrome 134 for all Chromium builds Raise minimum_chrome_version to 134 for every Chromium-based build (Chrome, Edge, Opera), matching the native Symbol.dispose and explicit-resource-management support the SDK's `using` disposal relies on, in place of the chrome-only override. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
4 lines
241 B
JavaScript
4 lines
241 B
JavaScript
// Stand-in for the core-js polyfill entry points in the Chrome build, where they are
|
|
// dropped as a build target replacement (see webpack.base.js). Loading it is a no-op:
|
|
// modern Chrome already provides the polyfilled behavior natively.
|