From ea5868271493376cb448c2b0bec2da83de31d30c Mon Sep 17 00:00:00 2001 From: Vicki League Date: Tue, 21 Apr 2026 14:16:48 -0400 Subject: [PATCH] [CL-1130] Fix a11y and storybook errors in UIF-owned code (#19921) --- .storybook/preview.tsx | 5 +- .storybook/test-runner.ts | 5 +- apps/browser/src/_locales/en/messages.json | 14 ++ .../popup/phishing-warning.stories.ts | 1 + .../popup/layout/popup-layout.stories.ts | 147 +++++++++++------- .../popup/layout/popup-page.component.html | 1 + .../popup-tab-navigation.component.html | 2 +- apps/desktop/src/locales/en/messages.json | 14 ++ .../navigation-switcher.stories.ts | 2 + apps/web/src/locales/en/messages.json | 16 +- .../v2/testing/story-mocks.ts | 1 + .../password-callout.stories.ts | 1 + .../src/callout/callout.component.html | 9 +- .../src/callout/callout.component.spec.ts | 1 + .../src/callout/callout.component.ts | 13 +- libs/components/src/callout/callout.mdx | 10 +- .../components/src/callout/callout.stories.ts | 34 ++-- .../src/dialog/dialog.service.stories.ts | 2 + .../src/dialog/dialog/dialog.component.html | 1 + ...ple-configurable-dialog.service.stories.ts | 1 + .../simple-dialog.component.html | 5 +- libs/components/src/icon/icon.component.ts | 1 + libs/components/src/item/item.stories.ts | 10 +- .../landing-layout/landing-layout.stories.ts | 18 ++- .../src/layout/layout.component.html | 8 +- libs/components/src/layout/mocks.ts | 3 + libs/components/src/menu/menu.component.html | 1 + .../src/navigation/nav-group.stories.ts | 2 + .../nav-item-interaction.stories.ts | 2 + .../src/navigation/nav-item.stories.ts | 2 + .../src/navigation/side-nav.component.html | 12 +- .../progress/progress-bar-lockup.stories.ts | 1 + .../src/progress/progress-bar.component.html | 6 +- .../src/progress/progress-bar.component.ts | 8 + libs/components/src/progress/progress-bar.mdx | 5 + .../src/progress/progress-bar.stories.ts | 17 +- .../kitchen-sink-empty.component.ts | 3 +- .../components/kitchen-sink-form.component.ts | 1 + .../kitchen-sink/kitchen-sink.stories.ts | 2 + libs/components/src/svg/svg.component.ts | 1 + libs/components/src/toast/toast.stories.ts | 1 + .../storage-card.component.stories.ts | 1 + .../subscription-card.component.stories.ts | 1 + package.json | 2 +- 44 files changed, 297 insertions(+), 96 deletions(-) diff --git a/.storybook/preview.tsx b/.storybook/preview.tsx index 699520d8f15..3ad8537fb0e 100644 --- a/.storybook/preview.tsx +++ b/.storybook/preview.tsx @@ -28,7 +28,10 @@ const preview: Preview = { ], parameters: { a11y: { - context: "#storybook-root", + context: { + include: ["#storybook-root", ".cdk-overlay-container"], + exclude: [".cdk-visually-hidden"], + }, }, controls: { matchers: { diff --git a/.storybook/test-runner.ts b/.storybook/test-runner.ts index 208adf96214..8a8519586a7 100644 --- a/.storybook/test-runner.ts +++ b/.storybook/test-runner.ts @@ -16,7 +16,10 @@ const testRunnerConfig: TestRunnerConfig = { page, // context - "#storybook-root", + { + include: ["#storybook-root", ".cdk-overlay-container"], + exclude: [".cdk-visually-hidden"], + }, // axeOptions, see https://www.deque.com/axe/core-documentation/api-documentation/#parameters-axerun { diff --git a/apps/browser/src/_locales/en/messages.json b/apps/browser/src/_locales/en/messages.json index 932c506f986..3900b038b96 100644 --- a/apps/browser/src/_locales/en/messages.json +++ b/apps/browser/src/_locales/en/messages.json @@ -6286,5 +6286,19 @@ }, "downloadFailed": { "message": "Failed to download." + }, + "sideNavigation": { + "message": "Side navigation" + }, + "skipLink": { + "message": "Skip link" + }, + "callout": { + "message": "Callout", + "description": "'Callout' is a noun. It is the name of a page component that displays at the top of a page and contains information like an alert or notification. This string will be used to label the callout for a screenreader when multiple callouts are on a page, like 'Callout 1' and 'Callout 2'." + }, + "progressBar": { + "message": "Progress bar", + "description": "This is the name of a page component that displays progress to the user. This string will be used to label the progress bar for a screenreader when multiple progress bars are on a page, like 'Progress bar 1' and 'Progress bar 2'." } } diff --git a/apps/browser/src/dirt/phishing-detection/popup/phishing-warning.stories.ts b/apps/browser/src/dirt/phishing-detection/popup/phishing-warning.stories.ts index f3c1fac7020..b15dd01909e 100644 --- a/apps/browser/src/dirt/phishing-detection/popup/phishing-warning.stories.ts +++ b/apps/browser/src/dirt/phishing-detection/popup/phishing-warning.stories.ts @@ -78,6 +78,7 @@ export default { learnMore: "Learn more", danger: "error", close: "Close", + callout: "Callout", }), }, { diff --git a/apps/browser/src/platform/popup/layout/popup-layout.stories.ts b/apps/browser/src/platform/popup/layout/popup-layout.stories.ts index 0321a169d18..c42488a8f8b 100644 --- a/apps/browser/src/platform/popup/layout/popup-layout.stories.ts +++ b/apps/browser/src/platform/popup/layout/popup-layout.stories.ts @@ -70,7 +70,7 @@ class ExtensionPoppedContainerComponent {} selector: "vault-placeholder", template: /*html*/ ` - +