mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-11-16 17:09:09 +00:00
With the previous change, newestAppLandStatus returned the newest omni-queue/land status among the App's and the unknown-creator ones. A newer `pending` or `error` whose creator GitHub does not report then hid the App's own `success`: a stored withdrawal was dropped and a pause of a landing-stage batch withdrew nothing, where before that change the `success` was withdrawn. An unknown-creator status may now only add a reason to withdraw, never remove one. The status that decides is the App's newest when it is `success`; else the newest among the App's and the unknown-creator ones when it is `success`; else nothing is withdrawn (the App's newest, or the newest unknown one, is returned for the callers' log lines). A status with a readable creator that is not the App's is still ignored for both tests. The comments of withdrawAbandoned and retryWithdrawals say the same. New tests (tick.test.mjs): the App's `success` under a newer `pending` or `error` of unknown creator is withdrawn on both paths: a stored withdrawal (kept with attempts 2 while the write is refused, written on the next tick) and a pause of a landing-stage batch; the App's `failure` newer than its `success`, nothing unknown, writes nothing on both paths. The tests of the previous change (an unknown `success` alone is withdrawn; another user's status is ignored) stay green. No test re-aimed.