mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-11-16 17:09:09 +00:00
A push to omni-queue/** has no github.event.pull_request, so the gates that are base-relative (or advisory) on a pull request ran a candidate in their absolute / strict mode. A base that drifted mid-cycle would red every candidate and the queue would blame innocent pull requests. Measured on the release tip: the strict i18n drift check exits 1 (33 sources, 66 mirrors). On a candidate these now compare with needs.changes.outputs.candidateBase: - ci.yml lint: boundary ratchet (--base-ref). - quality.yml fast-gates: file-size, complexity-ratchets, dead-code, boundary and the TS7 diagnostics ratchet (which was skipped without a base). - ci.yml docs-sync-strict: the i18n docs drift takes the pull-request path (base checkout of the candidate base + advisory comparison); the strict step no longer runs on a candidate. Pushes to main, merge_group and workflow_dispatch evaluate to the same values as before; pull requests keep github.event.pull_request.base.sha. newCodeMode.resolveMergeBase: on a merge-commit HEAD it compares with HEAD^1 (the live base tip of refs/pull/N/merge). A batch candidate is the base plus one merge commit per pull request, so that rule judged only the last pull request of the batch. The two new-code gates now pass the pushed ref, and a refs/heads/omni-queue/** ref compares with the given base. Every other ref keeps the first-parent rule. GITHUB_REF joins the runner-owned variables of check-env-doc-sync (the gates read it; it is not OmniRoute configuration). Existing assertions changed on purpose (same strictness, new expression): - tests/unit/build/check-boundary-ratchet.test.ts: the two exact matches of the PR_BASE_SHA binding (ci.yml lint, quality.yml fast-gates) now expect "github.event.pull_request.base.sha || needs.changes.outputs.candidateBase". - tests/unit/quality-rail-gate-membership.test.ts: the PR_BASE_SHA regex of the TS7 ratchet expects the same expression.