Files
Diego Rodrigues de Sa e Souza 191dce8d53 Release v3.8.53
Release v3.8.53 — 1,189 documented changes from 1,162 cycle commits and 208 contributor rows; full changelog in CHANGELOG.md → [3.8.53].

Merged by explicit owner decision at STOP #1 on head 6cc69650, without --admin (main has no required checks). Gate / CI passed on this head: 8 unit shards, Coverage and Quality Ratchet. Security: 0 npm, 0 CodeQL high, 0 Dependabot high.

Red at merge, accepted by the owner:
- Gate / Quality and Fast Quality Gates: complexity-ratchets and dead-code compare the whole cycle against main (11 dead exports; total complexity fell from 1,921 to 1,873). Cleanup follows in v3.8.54.
- dast-smoke: advisory.
- Release-Green: FAIL on `unit-6 no result` (cancelled at the 30-minute limit, cause not identified). Pack, boot and the other 64 commands passed on 7e640dee; there is no complete run on this head.

SonarQube is off (SONARQUBE_ENABLED=false). ⚠️ base-red inherited: #18791, #17267.
2026-11-06 04:21:00 -03:00

301 lines
11 KiB
TypeScript

import { describe, it } from "node:test";
import assert from "node:assert/strict";
import {
integrationIdFor,
parsePluginOptions,
PLUGIN_ID,
providerIdFor,
resolveTimeouts,
toResolvedOptions,
} from "../src/options.js";
describe("parsePluginOptions", () => {
it("applies the real default path via parsePluginOptions: freeOnly/toolsOnly/visionOnly all off", () => {
const opts = parsePluginOptions({ baseURL: "https://gw.example.com" });
assert.equal(opts.providerId, "omniroute");
assert.equal(opts.timeoutMs, 10000);
assert.equal(opts.usableOnly, false);
assert.equal(opts.enrichment, true);
assert.equal(opts.freeOnly, false);
// Owner decision 2026-10-07: the full catalog is the default again; toolsOnly is opt-in.
assert.equal(opts.toolsOnly, false);
assert.equal(opts.visionOnly, false);
assert.equal(opts.modelCacheTtlMs, undefined);
});
it("toolsOnly: true is an explicit opt-in to tool-calling models only", () => {
const opts = parsePluginOptions({ baseURL: "https://gw.example.com", toolsOnly: true });
assert.equal(opts.toolsOnly, true);
});
it("accepts a positive modelCacheTtlMs (in-memory TTL cache, default 300s)", () => {
const opts = parsePluginOptions({ baseURL: "https://gw.example.com", modelCacheTtlMs: 60000 });
assert.equal(opts.modelCacheTtlMs, 60000);
});
it("accepts a showcase size of seven", () => {
const opts = parsePluginOptions({
baseURL: "https://gw.example.com",
showcasePerOwner: 7,
});
assert.equal(opts.showcasePerOwner, 7);
});
it("leaves the showcase size unset when absent", () => {
const opts = parsePluginOptions({ baseURL: "https://gw.example.com" });
assert.equal(opts.showcasePerOwner, undefined);
});
it("accepts a custom showcase size", () => {
const opts = parsePluginOptions({ baseURL: "https://gw.example.com", showcasePerOwner: 3 });
assert.equal(opts.showcasePerOwner, 3);
});
it("rejects a non-positive showcase size", () => {
for (const showcasePerOwner of [0, -1, Number.NaN]) {
assert.throws(() =>
parsePluginOptions({ baseURL: "https://gw.example.com", showcasePerOwner })
);
}
});
it("rejects a non-numeric showcase size", () => {
assert.throws(() =>
parsePluginOptions({ baseURL: "https://gw.example.com", showcasePerOwner: "10" })
);
});
it("accepts a fresh cap of seven", () => {
const opts = parsePluginOptions({
baseURL: "https://gw.example.com",
freshPerOwner: 7,
});
assert.equal(opts.freshPerOwner, 7);
});
it("leaves the fresh cap unset when absent", () => {
const opts = parsePluginOptions({ baseURL: "https://gw.example.com" });
assert.equal(opts.freshPerOwner, undefined);
});
it("accepts a custom fresh cap", () => {
const opts = parsePluginOptions({ baseURL: "https://gw.example.com", freshPerOwner: 3 });
assert.equal(opts.freshPerOwner, 3);
});
it("accepts a freshness window of seven days", () => {
const opts = parsePluginOptions({
baseURL: "https://gw.example.com",
freshWindowDays: 7,
});
assert.equal(opts.freshWindowDays, 7);
});
it("leaves the usage memory unset when absent", () => {
const opts = parsePluginOptions({ baseURL: "https://gw.example.com" });
assert.equal(opts.usageMemory, undefined);
});
it("accepts usage memory true or false", () => {
assert.equal(
parsePluginOptions({ baseURL: "https://gw.example.com", usageMemory: true }).usageMemory,
true
);
assert.equal(
parsePluginOptions({ baseURL: "https://gw.example.com", usageMemory: false }).usageMemory,
false
);
});
it("rejects a non-boolean usage memory", () => {
for (const usageMemory of ["yes", 1]) {
assert.throws(() => parsePluginOptions({ baseURL: "https://gw.example.com", usageMemory }));
}
});
it("leaves the freshness window unset when absent", () => {
const opts = parsePluginOptions({ baseURL: "https://gw.example.com" });
assert.equal(opts.freshWindowDays, undefined);
});
it("accepts a wide freshness window", () => {
const opts = parsePluginOptions({ baseURL: "https://gw.example.com", freshWindowDays: 180 });
assert.equal(opts.freshWindowDays, 180);
});
it("rejects a non-positive freshness window", () => {
for (const freshWindowDays of [0, -1, Number.NaN]) {
assert.throws(() =>
parsePluginOptions({ baseURL: "https://gw.example.com", freshWindowDays })
);
}
});
it("rejects a non-numeric freshness window", () => {
assert.throws(() =>
parsePluginOptions({ baseURL: "https://gw.example.com", freshWindowDays: "90" })
);
});
it("rejects a non-positive fresh cap", () => {
for (const freshPerOwner of [0, -1, Number.NaN]) {
assert.throws(() => parsePluginOptions({ baseURL: "https://gw.example.com", freshPerOwner }));
}
});
it("rejects a non-numeric fresh cap", () => {
assert.throws(() =>
parsePluginOptions({ baseURL: "https://gw.example.com", freshPerOwner: "10" })
);
});
it("rejects a non-positive modelCacheTtlMs", () => {
assert.throws(() =>
parsePluginOptions({ baseURL: "https://gw.example.com", modelCacheTtlMs: 0 })
);
});
it("requires baseURL", () => {
assert.throws(() => parsePluginOptions({}), /baseURL/);
});
it("rejects a baseURL that is not an http(s) URL", () => {
// `new URL()` reads "localhost:20128" as the scheme "localhost:" followed
// by a path, so a gateway address typed without "http://" parses. Every
// model would then be published with "localhost:20128/v1" as its api url
// and every call would fail in the client on an unknown scheme, with no
// request on the wire and nothing in the gateway logs.
for (const baseURL of [
"localhost:20128",
"localhost:20128/v1",
"ftp://gw.example.com/v1",
"gw.example.com/v1",
]) {
assert.throws(
() => parsePluginOptions({ baseURL }),
/baseURL must be an http\(s\) URL/,
`expected ${baseURL} to be rejected`
);
}
});
it("accepts http and https baseURLs, with or without a port or path", () => {
for (const baseURL of [
"http://localhost:20128/v1",
"http://localhost:20128",
"https://gw.example.com/v1",
"https://gw.example.com/omniroute/v1",
]) {
assert.equal(parsePluginOptions({ baseURL }).baseURL, baseURL);
// Padding a copied address is trimmed rather than rejected, matching the
// treatment `headroomUrl` already gets in the settings schema.
assert.equal(parsePluginOptions({ baseURL: ` ${baseURL} ` }).baseURL, baseURL);
}
});
it("rejects unknown top-level keys (strict)", () => {
assert.throws(() => parsePluginOptions({ baseURL: "https://gw.example.com", bogus: 1 }));
});
it("rejects unknown apiFormat keys (strict)", () => {
assert.throws(() =>
parsePluginOptions({
baseURL: "https://gw.example.com",
apiFormat: { bogus: ["claude"] },
})
);
});
it("accepts deprecated anthropicPrefixes (warn at resolve time, not parse time)", () => {
const opts = parsePluginOptions({
baseURL: "https://gw.example.com",
apiFormat: { allowAnthropic: true, anthropicPrefixes: ["cc", "claude"] },
});
assert.deepEqual(opts.apiFormat, {
allowAnthropic: true,
anthropicPrefixes: ["cc", "claude"],
});
});
it("passes apiFormat allowlist through (shared enforces semantics)", () => {
const opts = parsePluginOptions({
baseURL: "https://gw.example.com",
apiFormat: { allowAnthropic: true, anthropicModels: ["anthropic/claude-x"] },
});
assert.deepEqual(opts.apiFormat, {
allowAnthropic: true,
anthropicModels: ["anthropic/claude-x"],
});
});
});
describe("identity table", () => {
it("maps providerId X to provider X and integration X, under one fixed plugin id", () => {
assert.equal(providerIdFor("omniroute"), "omniroute");
assert.equal(integrationIdFor("omniroute"), "omniroute");
assert.equal(providerIdFor("second-gateway"), "second-gateway");
// The host reads the plugin id before any option exists, so it never
// varies with providerId.
assert.equal(PLUGIN_ID, "omniroute-v2");
});
});
describe("invalid options say what to fix", () => {
it("names an unknown key instead of dumping the validator output", () => {
assert.throws(
() => parsePluginOptions({ baseURL: "http://gw.example.com", modelCacheTtl: 300000 }),
(err: Error) => {
assert.match(err.message, /invalid plugin options/);
assert.match(err.message, /unknown option "modelCacheTtl"/);
return true;
}
);
});
it("names the offending field for a wrong type", () => {
assert.throws(
() => parsePluginOptions({ baseURL: 42 }),
(err: Error) => {
assert.match(err.message, /baseURL/);
return true;
}
);
});
it("accepts the documented option names", () => {
const parsed = parsePluginOptions({
baseURL: "http://gw.example.com",
modelCacheTtlMs: 300000,
timeouts: { models: 15000, combos: 8000 },
geminiSanitization: false,
});
assert.equal(parsed.modelCacheTtlMs, 300000);
assert.equal(resolveTimeouts(parsed).models, 15000);
});
it("leaves providersAllow absent by default", () => {
assert.equal(
parsePluginOptions({ baseURL: "http://gw.example.com" }).providersAllow,
undefined
);
});
it("accepts a providersAllow list", () => {
assert.deepEqual(
parsePluginOptions({ baseURL: "http://gw.example.com", providersAllow: ["claude"] })
.providersAllow,
["claude"]
);
});
it("rejects a non-array providersAllow", () => {
assert.throws(() =>
parsePluginOptions({ baseURL: "http://gw.example.com", providersAllow: "cc" })
);
});
});
describe("providerId is bounded because it reaches a filesystem path", () => {
it("rejects a traversal attempt instead of writing outside the snapshot directory", () => {
for (const bad of ["../../etc/cron.d/x", "a/b", "..", "."]) {
assert.throws(
() => parsePluginOptions({ baseURL: "https://gw.example.com", providerId: bad }),
/invalid plugin options/,
`providerId ${JSON.stringify(bad)} must be rejected`
);
}
});
it("keeps the ids a user would actually pick", () => {
for (const ok of ["omniroute", "omniroute-2", "gw.staging", "gw_prod"]) {
assert.equal(
parsePluginOptions({ baseURL: "https://gw.example.com", providerId: ok }).providerId,
ok
);
}
});
});
describe("resolved relay defaults", () => {
it("relays the two free-signal defaults from parse to resolved options", () => {
const parsed = parsePluginOptions({ baseURL: "https://gw.example.com" });
assert.deepEqual(parsed.freeSignals, ["declared"]);
assert.equal(parsed.freeProviders, undefined);
const resolved = toResolvedOptions(parsed);
assert.deepEqual(resolved.freeSignals, ["declared"]);
assert.equal(resolved.freeProviders, undefined);
});
});