From a899236b3c551100b08954b722c3623b1ea45cf0 Mon Sep 17 00:00:00 2001 From: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com> Date: Tue, 28 Jul 2026 19:21:01 -0300 Subject: [PATCH] test(db): reword the driverFactory skip comment so the gate stops counting it MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The anti-test-masking gate greps text, not code: my explanation of WHY the better-sqlite3 guard moved out of the test body spelled the runner API out literally, and those two mentions inside a comment were counted as two new skip markers — the exact signal the previous commit set out to clear. Same explanation, phrased without the call syntax. Verified with the gate's own exported helpers against the merge-base: 0 modified-file violations, 0 deletion violations. Test still 15/15. --- tests/unit/db-adapters/driverFactory.test.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/unit/db-adapters/driverFactory.test.ts b/tests/unit/db-adapters/driverFactory.test.ts index 39c6ce8314c..8870ab6e331 100644 --- a/tests/unit/db-adapters/driverFactory.test.ts +++ b/tests/unit/db-adapters/driverFactory.test.ts @@ -46,9 +46,10 @@ describe("driverFactory", () => { // better-sqlite3 is an OPTIONAL dependency: on a platform with no prebuild and no // toolchain it simply will not load, and this expectation cannot hold. The condition is // declared in the test options (node:test evaluates it at declaration time) rather than - // via a mid-body t.skip() — same behavior, but the skip is visible in the report and the - // anti-test-masking gate can tell it apart from a `test.skip(...)` that silences a test - // unconditionally. + // from inside the test body — same behavior, but the skip is visible in the report and + // the anti-test-masking gate can tell it apart from a statically disabled test. (Phrased + // without the literal call syntax: that gate greps text, so spelling the API out here + // would count this comment as two new skip markers.) const betterSqliteProbe = tryOpenSync(":memory:"); const betterSqliteLoads = betterSqliteProbe?.driver === "better-sqlite3"; betterSqliteProbe?.close();