From 541cf620047c8cbf234b35e8c358e285c26384bd Mon Sep 17 00:00:00 2001 From: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com> Date: Sun, 15 Nov 2026 19:59:24 -0300 Subject: [PATCH] fix(ci): report i18n docs drift as DRIFT in Release-Green MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The --full-ci observer ran `npm run i18n:check` as a HARD item. Feature PRs no longer ship docs mirrors (the translation wave refreshes them at release), so between releases the mirrors are stale by design and the scheduled Release-Green reopened base-red #19329 with "docs-sync-strict -> npm run i18n:check: FAIL — drift detected" on every run since 2026-11-14. Declare the gate as drift in the static profile, like check:circular-deps. It still runs the same strict command (drift items do not get the pr gate mode) and the result stays visible in the drift bucket; it just no longer opens a base-red. The release cut keeps the strict verdict. The other i18n gates (UI coverage, ICU, ratio) stay HARD. --- config/quality/release-green-static-profile.json | 2 +- .../build/release-green-static-profile.test.mjs | 16 ++++++++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/config/quality/release-green-static-profile.json b/config/quality/release-green-static-profile.json index 2a03e56aeb5..00bb97f3a3d 100644 --- a/config/quality/release-green-static-profile.json +++ b/config/quality/release-green-static-profile.json @@ -358,7 +358,7 @@ "id": "i18n:check", "job": "docs-sync-strict", "args": ["run", "i18n:check"], - "kind": "hard", + "kind": "drift", "command": "node scripts/i18n/check-translation-drift.mjs" }, { diff --git a/tests/unit/build/release-green-static-profile.test.mjs b/tests/unit/build/release-green-static-profile.test.mjs index d9381d95e22..2683d55c4a9 100644 --- a/tests/unit/build/release-green-static-profile.test.mjs +++ b/tests/unit/build/release-green-static-profile.test.mjs @@ -152,6 +152,22 @@ test("declared required policy cannot be weakened by an old curated drift bucket assert.equal(fullCiKindFor("check:circular-deps", [], "drift"), "drift"); }); +test("i18n docs drift is a DRIFT item: mirrors are refreshed by the release wave", () => { + // Plan "derived numbers and texts resolved only at release" (2026-11-13): feature PRs no + // longer ship docs mirrors, the translation wave refreshes them at release, so between + // releases they are stale by design. The strict verdict stays visible as drift (it runs + // without the pr gate mode the HARD bucket gets) and never opens a base-red; the release + // cut keeps it blocking. + const gate = loadFullCiProfile(root, fixedBase).find((g) => g.id === "i18n:check"); + assert.equal(gate.kind, "drift"); + assert.deepEqual(gate.args, ["run", "i18n:check"], "same strict command, no --warn"); + assert.equal(fullCiKindFor("i18n:check", [], gate.kind), "drift"); + for (const id of ["i18n:check-ui-coverage", "check:ui-icu", "i18n:check-ratio"]) { + const other = loadFullCiProfile(root, fixedBase).find((g) => g.id === id); + assert.equal(other.kind, "hard", `${id} stays HARD`); + } +}); + test("test-masking receives a fixed base SHA in the full profile", () => { resolvedRefs.length = 0; const gate = loadFullCiProfile(root, fixedBase).find((g) => g.id === "check:test-masking");